Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Student viewing rubric results: average doesn't match #12065

Closed
damithc opened this issue Feb 9, 2023 · 2 comments · Fixed by #12066
Closed

Student viewing rubric results: average doesn't match #12065

damithc opened this issue Feb 9, 2023 · 2 comments · Fixed by #12066
Labels
p.Critical Would like to fix ASAP and release as a hot patch s.ToInvestigate The issue sounds complete but needs validation by a core team member

Comments

@damithc
Copy link
Contributor

damithc commented Feb 9, 2023

v8.22
Reported by a user.
Shouldn't this be 10, as the student received 10 from all others?

image

Possibly related to #11984

The previous version (v8.19.2) produces 10 as the average, for the same data:

image
@damithc damithc added p.Critical Would like to fix ASAP and release as a hot patch s.ToInvestigate The issue sounds complete but needs validation by a core team member labels Feb 9, 2023
@damithc
Copy link
Contributor Author

damithc commented Feb 9, 2023

Reverting #11984 (at least for the time being) is one option, given that it would also take care of #12064

@samuelfangjw
Copy link
Member

samuelfangjw commented Feb 9, 2023 •
edited
Loading

Reverting #11984 (at least for the time being) is one option, given that it would also take care of #12064

We have a fix for this ready, should be able to hot fix by tomorrow. If that's the case, I'm of the opinion that #12064 alone doesn't warrant a rollback.

@zhaojj2209 zhaojj2209 mentioned this issue Feb 9, 2023
Merged
zhaojj2209 added a commit that referenced this issue Feb 10, 2023
@zhaojj2209
[#12065] Student viewing rubric results: average doesn't match (#12066)
50fff21 
* Fix rubric stats calculation

* Fix tests
weiquu added a commit to weiquu/teammates that referenced this issue Feb 18, 2023
@weiquu
Revert "[TEAMMATES#12065] Student viewing rubric results: average doe…
4e5a518 
…sn't match (TEAMMATES#12066)"

This reverts commit 50fff21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p.Critical Would like to fix ASAP and release as a hot patch s.ToInvestigate The issue sounds complete but needs validation by a core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12065] Student viewing rubric results: average doesn't match zhaojj2209/teammates
2 participants
@damithc @samuelfangjw