Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor courses page: some items don't show spinners #10508

Closed
damithc opened this issue Aug 2, 2020 · 5 comments · Fixed by #12521
Closed

Instructor courses page: some items don't show spinners #10508

damithc opened this issue Aug 2, 2020 · 5 comments · Fixed by #12521
Labels
p.Low Very little impact; unlikely to do in the near future

Comments

@damithc
Copy link
Contributor

damithc commented Aug 2, 2020

Current: The courses page has three tables that seem to load independently of each other. However, only one spinner is shown.
image

Suggestion: Add a spinner for each.
@damithc damithc added the p.Low Very little impact; unlikely to do in the near future label Aug 2, 2020
@wkurniawan07
Copy link
Member

It's not the same problem. Archived courses and deleted courses won't be shown at all if there are none of them, as opposed to the active courses page which will show something like "You do not have any active courses" if there is none, so the spinner might end up into nothingness which is weird.

@damithc
Copy link
Contributor Author

damithc commented Aug 3, 2020

It's not the same problem. Archived courses and deleted courses won't be shown at all if there are none of them, as opposed to the active courses page which will show something like "You do not have any active courses" if there is none, so the spinner might end up into nothingness which is weird.

I think empty tables should be shown even if there are no deleted/archived items. That's more consistent with our policy that even disabled items are shown to let users know where things are.

@wkurniawan07
Copy link
Member

I think empty tables should be shown even if there are no deleted/archived items.

I'll just leave a note that V6 didn't do this.

@wkurniawan07 wkurniawan07 added the s.NeedsInfo More information is needed from the issue reporter label Aug 5, 2020
@wkurniawan07 wkurniawan07 removed the s.NeedsInfo More information is needed from the issue reporter label Sep 19, 2020
@rexong
Copy link
Contributor

rexong commented Jul 16, 2023

Hi, can I start a PR for this?

@github-actions github-actions bot mentioned this issue Jul 16, 2023
Open
@domlimm
Copy link
Contributor

domlimm commented Jul 16, 2023

@rexong Sure, feel free to submit a PR!

@rexong rexong mentioned this issue Jul 16, 2023
Merged
This was referenced Jul 23, 2023
Open
Open
Open
Open
Open
jasonqiu212 pushed a commit that referenced this issue Jul 31, 2023
@rexong
[#10508] Instructor courses page: some items don't show spinners (#12521
37c81b8 
)

* Unhide archive and delete table

* Add alerts if archive and bin is empty

* Add Spinner to all tables in courses page

* Update snapshots

* Change isLoadingSoftDeleteCourses to isLoadingSoftDeletedCourses
@jasonqiu212 jasonqiu212 mentioned this issue Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#10508] Instructor courses page: some items don't show spinners rexong/teammates
4 participants
@damithc @wkurniawan07 @domlimm @rexong