Move Paho Client Log Messages into Log at Same Level #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging of the Paho Client was previously available through a somewhat hidden log level of 5. This means that Paho Error messages were only visible in the log if the logging level was at 5 or lower. This change moves all Paho Client log messages into the log at their defined level. So if a user has Error messages enabled Paho Error messages will appear in the log. The one exception, is that the Paho Client logs ping messages at the debug level, which is a little verbose I think for our needs. So all logging of ping messages have been moved to level 5. Added notes to the config example about the level 5 logging level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Logging of the Paho Client was previously available through a somewhat hidden log level of 5. This means that Paho Error messages were only visible in the log if the logging level was at 5 or lower.
This change moves all Paho Client log messages into the log at their defined level. So if a user has Error messages enabled
Paho Error messages will appear in the log.
The one exception, is that the Paho Client logs ping messages at the debug level, which is a little verbose I think for our needs.
So all logging of ping messages have been moved to level 5.
Added notes to the config example about the level 5 logging level.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: