Remove Need to Refresh Modem Database #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing errors in the Modem DB defined spec.
There is no reason we need the cache to perform an accurate DB Delete. It would be a much better user experience if we recoverd from any errors in the delete. To do this, we search for all entries that match addr and group on the modem and remove them from the cache. We then ask the Modem to provide us only the entries that match addr and group and add them back to the end of our db cache. We then perform the delete as we did previously, which should never result in a NAK.
If an add is attempted and the entry already exists we get a nack and then we attempt the same entry as an update. The vice-versa is true of a update as well. This means users will no longer get the modem db is out of date please refresh warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is pretty cool. I have reworked the Modem delete/add/modify routines so that they no longer care or require a refresh of the modem database. This means things like pair, sync, and adding links should no longer fail because the Modem db is out of date.
In short, if you try and add a link that already exists, the modem will return a nak. At which point we retry the action as an update instead. The same is true if you try to update a link that doesn't exist. The delete is a little more complicated and requires us to search the database first, but we can search specifically for these links.
The cool thing is that this all happens in less than a second, so it isn't even noticable to users.
The only real need to refresh the modem db now is if you want to run sync to delete extraneous entries. Otherwise, an out of date modem db shouldn't be an issue anymore.
This is also a prime example of how bad the insteon documentation is. The documentation about these commands is wrong a lot. I had to poke at things a fair bit to determine how it actually works.
I still have to write some tests to ensure that everything works as intended. But I have tested all of the various iterations on actual hardware and it works great.