Tweak Logging Levels and Messages #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With longer delays particularly on db read of i2 devices, the length between messages may exceed 10 seconds now.
Warning will be outputed to users, so it should be something that we expect all users to encounter. Try to make some messages more clear
Move message to someplace more logical and add better instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning messages will be outputted in the MQTT messages and the command line, so they should be true warnings that we expect all users to see.
Some of our warnings were more suited as info.
Also improved the text of a few warnings.
Finally increased the command time out now that we have potentially long timeouts on db_get.