Last Entry Can be Used #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notes in the device db contain the following: The last entry in the database. Devices show an unused, null (all zeros) marked with the LAST bit set in the db. From the docs this shouldn't be required - the LAST bit can be a usable entry but it doesn't appear to work. Which suggests that having the last entry be a usable one doesn't work. But some of the errors in TD22057#231 suggest that maybe duplicating entries no longer works. This instead sets the last entry to all 0x00s which is what a factory reset entry looks like. I have hopes that this may solve generic NAK errors on new devices when adding entries using a new address.
Insteon devices always keep the last memory location as unused and all 0x00s. However, it looks like ISY may use the last location. Our code also didn't treat the last_loc as unused even when it was marked as so. Now, the last_loc is only put in the unused array if it is unused. This means that to write to an existing mem_loc we need >1 unused address. To bring an ISY database into alignment with how we use it if the last loc is used, we do 3 things. 1. Change the last_loc flag on the current last entry to false 2. Write the new entry in the slot just below #1 marked as used and not last 3. Write a new all 0x00 entry marked unused and last below #2 Finally rearrange how we write new entrys so that: 1. Write the new entry in the slot currently marked as last 2. Write a new all 0x00 entry marked unused and last below #2 This could mean that if things fail before #2 happens a bunch of bizarre old links may reappear, but I think this is extremely unlikely, and organizing it this way enables the ISY fix to be done in only 3 database writes.
Fixed Conflicts: insteon_mqtt/db/Device.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the database object to reflect the possibility that the last entry may not be an unused entry.
If the last entry is used, when adding entries to new memory locations, add an additional blank unused entry so that the last entry is unused.
Not exactly what the original issue was opened about, but this was the result of the review.
Closes #250