Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect disconnections during poll() calls #227

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

kpfleming
Copy link
Contributor

The Paho-MQTT client may not invoke the 'on_disconnect'
callback when used with an external loop, so check for connection
loss during calls to loop_misc() and handle it appropriately.

Closes #222.

The Paho-MQTT client may not invoke the 'on_disconnect'
callback when used with an external loop, so check for connection
loss during calls to loop_misc() and handle it appropriately.

Closes TD22057#222.
Copy link
Collaborator

@krkeegan krkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge this. I have never seen this issue, but the fix seems reasonable enough.

@krkeegan krkeegan merged commit cb6726c into TD22057:dev Dec 11, 2020
@kpfleming kpfleming deleted the fix-reconnection branch December 11, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants