Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change scene topic to use name #130

Closed
elperepat opened this issue Mar 11, 2019 · 1 comment
Closed

Cannot change scene topic to use name #130

elperepat opened this issue Mar 11, 2019 · 1 comment

Comments

@elperepat
Copy link

Hi!

Just discovered this software and am quite impressed. Seems to work pretty well.

However, I prefer to use {{name}} instead of {{address}} in the topics.

There seem to be a bug in the scene topic handling though. In the config.yaml on lines 231 and 322, the topic template is:

scene_topic: 'insteon/{{address}}/scene'

but in insteon_mqtt/mqtt/Switch.py on line 97
the code looks for scene_on_off_topic and not scene_topic:

self.msg_scene_on_off.load_config(config, 'scene_on_off_topic', 'scene_on_off_payload', qos)

Same for scene_payload vs scene_on_off_payload on lines 232 and 323 of config.yaml

I didn't do a pull request as I don't know which one you prefer.

Thanks!

Patrick

@TD22057
Copy link
Owner

TD22057 commented Mar 16, 2019

Thanks. Fixed. Since everyone has the same config file, I updated the code to match the config file. I had written tests for those but didn't notice the config file was using a different naming scheme.

@TD22057 TD22057 closed this as completed Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants