-
Notifications
You must be signed in to change notification settings - Fork 25
Add timeEstimate
to PaymentMethod
#263
Comments
Like my comment in #262, I would try to follow existing payment industry practices to the extent possible here. Is there such a field in other financial transaction protocol, such as SWIFT? If so, great, copy it. If not, I'd think hard before inventing something new in this space. |
I like this, especially in cases where as a customer is considering multiple PFIs |
From digging through SWIFT I could not find an analogous concept; however, if LPs (fka PFIs) provide this type of data then I believe it would be useful to include in our |
@angiejones or even just multiple payment methods in a single offering. esp. given that different methods can have different fees associated to them. it adds a whole new layer to price off of |
thanks so much for digging into SWIFT and looking. i couldn't find anything either. i think LPs will sorta have to if we make it required and it's something i personally am in favor of if for no other reason than acting as a means to keep LPs honest / accountable. Technically speaking, Alice has a provable way to show that an LP either did or didn't deliver within the estimated settlement time simply by showing the message exchange between her and the LP. |
Excellent point this is a good piece of data we can use to score PFIs |
minor snag here w.r.t. making this a required field for Note fields omitted for brevity {
"metadata": {
"from": "did:ex:pfi",
"kind": "offering",
"id": "offering_01ha82y8d0fhstg95hhfjwmgxf",
"createdAt": "2023-09-13T20:15:22.528Z",
"protocol": "1.0"
},
"data": {
"description": "Selling BTC for USD",
"payoutUnitsPerPayinUnit": "0.00003826",
"payin": {
"currencyCode": "USD",
"methods": [
{
"kind": "DEBIT_CARD",
"estimatedSettlementTime": 60 <--- weird?
}
]
},
"payout": {
"currencyCode": "BTC",
"max": "999526.11",
"methods": [
{
"kind": "BTC_ADDRESS",
"estimatedSettlementTime": 3600
}
]
}
}
} options here are:
I prefer option 1. have a feeling that no pfi will use the field if it's optional esp. if concerned about scoring. |
Agree with option 1 |
Co-Authored-By: corcillo <[email protected]>
* address #260 * update schemas to reflect changes described in #260 * address #261 * address #262 * address #263 Co-Authored-By: corcillo <[email protected]> * address #253 * Update specs/protocol/README.md Co-authored-by: Kendall Weihe <[email protected]> * Apply suggestions from code review Co-authored-by: Gabe <[email protected]> * Update specs/protocol/README.md Co-authored-by: Kendall Weihe <[email protected]> * Update specs/protocol/README.md Co-authored-by: phoebe-lew <[email protected]> * Update specs/protocol/README.md Co-authored-by: Kendall Weihe <[email protected]> * Update specs/protocol/README.md Co-authored-by: phoebe-lew <[email protected]> * add description for `estimatedSettlementTime` * Update hosted/json-schemas/offering.schema.json Co-authored-by: Gabe <[email protected]> * narrow type for `requiredPaymentDetails` Co-Authored-By: Gabe <[email protected]> * fomatting --------- Co-authored-by: corcillo <[email protected]> Co-authored-by: Kendall Weihe <[email protected]> Co-authored-by: Gabe <[email protected]> Co-authored-by: phoebe-lew <[email protected]>
PaymentMethod is the type used for the elements within
Offering.payinMethods[]
andOffering.payoutMethods[]
.including a property that alows PFIs to convey the estimated settlement time based on a given payment method could be very informative to individuals.
Proposing we add a field to
PaymentMethod
that allows PFIs to convey this information. haven't yet decided onestimatedSettlementTime
?The text was updated successfully, but these errors were encountered: