This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, test vectors lived alongside normal unit tests. This caused a few pain points:
Web5TestVectors
.test_resolve
run theresolve
test vector, or does it run a unit test on theresolve
function? It was impossible to tell without intimate knowledge of the test itself, or the use of rigorous naming conventions of the tests themselves (which isn't possible, because the test names have their own naming convention according to the spec).did_jwk/resolve
has three separate vectors defined within the resource JSON file. If one vector failed, but the other two succeeded, the test would fail and the output gave no indication as to which of the vectors failed. The developer would need to manually inspect the test with breakpoints in order to determine which one it was. This was time consuming, and just overall a bad experience.To address these pain points, I have refactored how test vectors work in this package.
Changes made:
Web5TestVectors
.TestUtilities
target.XCTActivity
, allowing us to know which of the vectors actually failed.