This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Convert Gradle to Maven Build #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALRubinger
force-pushed
the
issue-204/maven-build
branch
7 times, most recently
from
8c5a1cf to
3bb22a7
Compare
ALRubinger
force-pushed
the
issue-204/maven-build
branch
from
4ac61e8 to
43fcc95
Compare
ALRubinger
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
michaelneale,
KendallWeihe,
ethanwlee,
tomdaffurn,
diehuxx,
kirahsapong and
nitro-neal
as code owners
jiyoonie9
reviewed
Apr 4, 2024
jiyoonie9
reviewed
Apr 4, 2024
README.md
Outdated
|
|
||
| * [`/protocol`](./protocol/) - create, parse, verify, and validate the tbdex messages and resources defined in | ||
| the [protocol draft specification](https://github.com/TBD54566975/tbdex/blob/main/specs/protocol/README.md) | ||
| * [`/httpclient`](./httpclient) - An HTTP client that can be used to send tbdex messages to PFIs | ||
| * [`/httpserver`](./httpserver) - Base implementation of a tbDEX HTTP server responsible for handling RFQs, orders, and other interactions | ||
|
|
There was a problem hiding this comment.
do we not get something like this for tbdex? i saw it in your web5-kt pr
* [tbdex](./tbdex) - The full tbdex platform
There was a problem hiding this comment.
Noted in one of my comments on this PR that we need to handle, yes - thx
config/dokka-configuration.json
Outdated
There was a problem hiding this comment.
|
Must document in AND also document in |
|
Add to |
* Add Maven Build * Remove Gradle * Build and tests passing * Add distribution for single dependency to get all of tbDEX * Update all GitHub Actions workflows * Add Dokka API Documentation config and manual generation script * Address @jiyoontbd PR feedback Next: * Validate with Dev Site * Remove ALRubinger SCM config for publishing * Remove comments on mvn deploy to Sonatype * Remove comments on ci.yml for Publishing test vectors
ALRubinger
force-pushed
the
issue-204/maven-build
branch
from
4572271 to
4cee120
Compare
ALRubinger
force-pushed
the
issue-204/maven-build
branch
from
4cee120 to
55d9a38
Compare
leordev
approved these changes
Apr 5, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to go for review. Do not merge until the web5-kt PR below is merged and a proper release is cut there, and updated here.
I'll avoid repetition here. Reasoning and layout is same as extensively detailed in:
Deployed a Release Candidate build: https://blockxyz.jfrog.io/artifactory/tbd-oss-releases-maven2/xyz/block/tbdex/1.0.0-maven-rc-1/
This has been validated as working in
developer.tbd.website:Accomplishes the principal goal: make it so that consumers of
tbdex-ktget versioning aligned withweb5-ktwithout the need to do any manual dependency coordination by appdevs. Proven by the dev site testsuite POM: https://github.com/TBD54566975/developer.tbd.website/blob/alrubinger/tbdex-upgrade-v1-kt-maven/site/testsuites/testsuite-kotlin/pom.xml#L30