This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
pulling in latest test vector update from tbdex #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to update commit hash to point to the commit when this tbdex PR gets merged |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 77.58% 77.55% -0.03%
==========================================
Files 33 33
Lines 812 811 -1
Branches 80 80
==========================================
- Hits 630 629 -1
Misses 135 135
Partials 47 47
|
jiyoonie9
requested review from
mistermoe,
phoebe-lew,
michaelneale,
KendallWeihe,
ethanwlee,
tomdaffurn,
diehuxx and
kirahsapong
as code owners
diehuxx
approved these changes
Feb 26, 2024
| @@ -107,8 +107,7 @@ object CryptoUtils { | |||
| Crypto.verify( | |||
| publicKey = publicKeyJwk, | |||
| signedPayload = jws.signingInput, | |||
| signature = jws.signature.decode(), | |||
| algorithm = jws.header.algorithm | |||
There was a problem hiding this comment.
I'm guessing the latest web5 changed this function signature?
(I ask because it's tangential to the title of this PR)
There was a problem hiding this comment.
yes, correct! now we're not asking for algorithm from the caller, we figure it out by looking at the publicKey instead :)
KendallWeihe
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also bumps web5-kt version so it includes fixes for kt did:dht resolution per decentralized-identity/web5-kt#251