-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
…ion per running ./gradlew --version). replaced gradlew wrapper validator action with init hermit step to publish ci and docs yaml
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 33 33
Lines 812 812
Branches 80 80
=======================================
Hits 630 630
Misses 135 135
Partials 47 47
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! pinging the hermit himself @alecthomas anything stand out?
only other thing which comes to my mind is maybe adding relevant developer instructions to the README
Ah yes, one thing: I would suggest not using channels. I'd pin the versions exactly then either manually upgrade them, or use Renovate to manage them - it has Hermit support. |
Also, you'll need to add this to your
That will prevent Gradle from trying to download the wrapper automatically. |
oh this would be nice - then I don't have to mess around with JVM versions by hand? |
@@ -30,7 +32,7 @@ jobs: | |||
key: gradle-${{ runner.os }}-${{ hashFiles('**/*.gradle.kts') }}-${{ hashFiles('**/gradle/wrapper/gradle-wrapper.properties') }}-${{ hashFiles('**/versions.properties') }} | |||
|
|||
- name: Run Gradle Tasks | |||
run: ./gradlew build koverXmlReport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI it's not necessary to include bin/
here - activate-hermit
will add bin
to the $PATH
for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
replaced gradlew wrapper validator action with init hermit step to publish ci and docs yaml