This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Update currency representation #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
michaelneale,
KendallWeihe,
ethanwlee and
tomdaffurn
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 78.39% 78.64% +0.25%
==========================================
Files 30 30
Lines 671 693 +22
Branches 65 65
==========================================
+ Hits 526 545 +19
- Misses 111 114 +3
Partials 34 34
|
phoebe-lew
approved these changes
Jan 15, 2024
| * @throws Exception if validation fails, including a list of validation errors. | ||
| */ | ||
| fun validateMessage(message: Message) { | ||
| val mapper = ObjectMapper() |
There was a problem hiding this comment.
You can use the jsonMapper from Json.kt instead of reinstantiating
| * @throws Exception if validation fails, including a list of validation errors. | ||
| */ | ||
| fun validateData(data: Data, messageKind: String) { | ||
| val mapper = ObjectMapper() |
There was a problem hiding this comment.
ditto: You can use the jsonMapper from Json.kt instead of reinstantiating
This was referenced Jan 15, 2024
jiyoonie9
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #114, see also spec change TBD54566975/tbdex#206 and equivalent js PR TBD54566975/tbdex-js#134
There are a few places where we are not validating data upon Message/resource creation or sending. In those places, i added JSON Schema validations. These additional checks helped me find default data and test data that needed to be updated.