feat: proxy calls through the runner #3586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2024
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/runner-proxy
branch
4 times, most recently
from
4b48645
to
03ad2f0
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/runner-proxy
branch
from
03ad2f0
to
376dcfd
Compare
alecthomas
approved these changes
Dec 1, 2024
| if err != nil { | ||
| return fmt.Errorf("failed to send message: %w", err) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
There should be a check here for if moduleContext.Err() != nil, which can happen if the server closes the connection cleanly. Otherwise below will report a nil error as an error.
| } | ||
|
|
||
| func (r *runnerProxy) GetModuleContext(ctx context.Context, c *connect.Request[ftlv1.GetModuleContextRequest], c2 *connect.ServerStream[ftlv1.GetModuleContextResponse]) error { | ||
| moduleContext, err := r.controllerModuleService.GetModuleContext(ctx, connect.NewRequest(c.Msg)) |
There was a problem hiding this comment.
I think these calls to connect.NewRequest() are going to drop all headers, even ones we want to preserve?
There was a problem hiding this comment.
It's been a while but I think this is automatically handled by middleware + headers in the context...so maybe disregard!
| @@ -397,7 +406,8 @@ func (s *Service) deploy(ctx context.Context, key model.DeploymentKey, module *s | |||
| return fmt.Errorf("failed to download artefacts: %w", err) | |||
| } | |||
|
|
|||
| envVars := []string{"FTL_ENDPOINT=" + s.config.ControllerEndpoint.String(), | |||
| logger.Infof("Setting FTL_ENDPOINT to %s", s.proxy.bindAddress.String()) | |||
There was a problem hiding this comment.
Should be debugf to avoid showing to user during local dev. We should really solve this differently, but for now that's the way it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.