feat: move ingress to it's own service #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
Open
Open
stuartwdouglas
added
the
run-all
stuartwdouglas
force-pushed
the
stuartwdouglas/ingress-service
branch
from
4293d18
to
d07a352
Compare
stuartwdouglas
added
the
skip-proto-breaking
stuartwdouglas
force-pushed
the
stuartwdouglas/ingress-service
branch
from
d07a352
to
4e1f26b
Compare
stuartwdouglas
requested review from
wesbillman
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/ingress-service
branch
4 times, most recently
from
788913c
to
a06d216
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/ingress-service
branch
10 times, most recently
from
1e38f31
to
efa0457
Compare
alecthomas
approved these changes
Nov 25, 2024
| @@ -0,0 +1,5 @@ | |||
| -- migrate:up | |||
| DROP TABLE IF EXISTS ingress_routes; | |||
backend/ingress/service.go
Outdated
| }) | ||
| err := wg.Wait() | ||
| if err != nil { | ||
| return fmt.Errorf("cron service stopped: %w", err) |
There was a problem hiding this comment.
copy pasta cron -> ingress
stuartwdouglas
force-pushed
the
stuartwdouglas/ingress-service
branch
from
efa0457
to
83a37f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.