fix: allow all origins in devMode #3444
Conversation
frontend/cli/cmd_serve.go
Outdated
| // Add controller address to allow origins for console requests. | ||
| // The console is run on `localhost` so we replace 127.0.0.1 with localhost. | ||
| if addr.Hostname() == "127.0.0.1" { | ||
| addr.Host = "localhost" + ":" + addr.Port() |
There was a problem hiding this comment.
FWIW we shouldn't run on "localhost" as it can trigger Mac security popups.
There was a problem hiding this comment.
Yeah this one is interesting. I had to add this to solve a problem with running locally with my mac and it's working currently, but I def want to do whatever is correct here. Lemme try a few things here before merging, but this part of the code has been around for a while.
frontend/cli/cmd_serve.go
Outdated
|
|
||
| if devMode && len(s.CommonConfig.AllowHeaders) == 0 { | ||
| // Default to allowing all headers for console requests in local dev mode. | ||
| if devMode { |
There was a problem hiding this comment.
Not related to this PR but I just realised - what is "!devMode"? ftl dev/ftl serve are always dev mode...
There was a problem hiding this comment.
haha! I had the exact same question/thought when i was doing this. I think it's a flag that gets passed in and needs to get forwarded onto other code from within the cmd_serve. But it's only used/set by cmd_dev and it's always true.
wesbillman
force-pushed
the
make-allow-origins-all-dev-default
branch
from
309be0e
to
9ba1687
Compare
No description provided.