feat: inject topics/subscriptions in go #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
from
e747065
to
2d24683
Compare
Base automatically changed from
worstell/20241114-publisher-metadata
to
main
November 18, 2024 17:49
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
2 times, most recently
from
31ba8b6
to
0f01e0c
Compare
worstell
changed the base branch from
main
to
worstell/20241119-deterministic-order-for-verb-resources
worstell
force-pushed
the
worstell/20241119-deterministic-order-for-verb-resources
branch
2 times, most recently
from
10b9386
to
366f26b
Compare
Base automatically changed from
worstell/20241119-deterministic-order-for-verb-resources
to
main
November 19, 2024 23:46
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
3 times, most recently
from
8e1ee84
to
65f6b88
Compare
worstell
commented
Nov 19, 2024
| @@ -565,7 +567,8 @@ func testErrorReporting(t *testing.T) { | |||
| `146:6-45: enum discriminator "TypeEnum3" cannot contain exported methods`, | |||
| `149:6-35: enum discriminator "NoMethodsTypeEnum" must define at least one method`, | |||
| `161:3-14: unexpected token "d"`, | |||
| `168:2-62: can not publish directly to topics in other modules`, | |||
| // todo: do we want this? why do we support exporting topics if so? | |||
| //`168:2-62: can not publish directly to topics in other modules`, | |||
There was a problem hiding this comment.
should this check be removed?
There was a problem hiding this comment.
Ah we still want this limitation. We export topics so that subscriptions in other modules can subscribe to them. But we don't want to let anyone publish to topics directly.
There was a problem hiding this comment.
ah ok cool, i'll restrict that via the generated external module so there's no Publish method at all
There was a problem hiding this comment.
actually that won't work. will keep the static check
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
2 times, most recently
from
cc3d236
to
29f4e24
Compare
worstell
commented
Nov 20, 2024
| @@ -438,67 +438,6 @@ func getDSNFromSecret(ftl internal.FTL, module, name string) (string, error) { | |||
| return dsn, nil | |||
| } | |||
|
|
|||
| // WithSubscriber adds a subscriber during a test | |||
There was a problem hiding this comment.
will be reimplementing test helpers with a different strategy separately
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
5 times, most recently
from
97232ae
to
b446f7e
Compare
worstell
changed the title
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
from
45afd0b
to
26ea38c
Compare
worstell
requested review from
stuartwdouglas and
wesbillman
and removed request for
a team
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
2 times, most recently
from
99f183e
to
c094dc2
Compare
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
3 times, most recently
from
24e9479
to
8ca7ac7
Compare
worstell
force-pushed
the
worstell/20241114-pubsub-injection
branch
from
c551c75
to
d3effd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go:
type MyTopic = ftl.TopicHandle[MyEvent]schema:
topic myTopic foo.MyEventgo:
type MySubscription = ftl.SubscriptionHandle[MyTopic, MySinkClient, MyEvent]schema:
subscription mySubscription foo.MyEvent