feat: timeout for deploy command #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
added
the
run-all
stuartwdouglas
requested review from
wesbillman
and removed request for
a team
This was referenced Nov 6, 2024
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/deploy-timeout
branch
3 times, most recently
from
ca07e3a
to
7783991
Compare
alecthomas
reviewed
Nov 7, 2024
frontend/cli/cmd_deploy.go
Outdated
| @@ -37,5 +40,10 @@ func (d *deployCmd) Run(ctx context.Context, projConfig projectconfig.Config) er | |||
| if err != nil { | |||
| return err | |||
| } | |||
| return engine.BuildAndDeploy(ctx, d.Replicas, !d.NoWait) | |||
| tm := optional.None[time.Duration]() | |||
| if d.Timeout.Milliseconds() > 0 { | |||
There was a problem hiding this comment.
FYI you can just compare d.Timeout > 0
frontend/cli/cmd_deploy.go
Outdated
Comment on lines
44
to
47
| tm := optional.None[time.Duration]() | ||
| if d.Timeout.Milliseconds() > 0 { | ||
| tm = optional.Some(d.Timeout) | ||
| } |
There was a problem hiding this comment.
You can replace this with:
Suggested change
| tm := optional.None[time.Duration]() | |
| if d.Timeout.Milliseconds() > 0 { | |
| tm = optional.Some(d.Timeout) | |
| } | |
| tm := optional.Zero(d.Timeout) |
internal/buildengine/engine.go
Outdated
| @@ -755,7 +755,7 @@ func (e *Engine) getDependentModuleNames(moduleName string) []string { | |||
| } | |||
|
|
|||
| // BuildAndDeploy attempts to build and deploy all local modules. | |||
| func (e *Engine) BuildAndDeploy(ctx context.Context, replicas int32, waitForDeployOnline bool, moduleNames ...string) error { | |||
| func (e *Engine) BuildAndDeploy(ctx context.Context, replicas int32, waitForDeployOnline bool, timeout optional.Option[time.Duration], moduleNames ...string) error { | |||
There was a problem hiding this comment.
It's much more idiomatic to use the context for timeouts.
stuartwdouglas
force-pushed
the
stuartwdouglas/deploy-timeout
branch
6 times, most recently
from
0e6ea0e
to
0b5b535
Compare
alecthomas
approved these changes
Nov 18, 2024
stuartwdouglas
force-pushed
the
stuartwdouglas/deploy-timeout
branch
2 times, most recently
from
67f017e
to
8d32f25
Compare
Also limit test deploy to 1m to help diagnose issues
stuartwdouglas
force-pushed
the
stuartwdouglas/deploy-timeout
branch
from
8d32f25
to
ad3f17b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also limit test deploy to 1m to help diagnose issues