Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong spider example with hidden modules #283

Closed
vanzod opened this issue Jun 8, 2017 · 3 comments
Closed

Wrong spider example with hidden modules #283

vanzod opened this issue Jun 8, 2017 · 3 comments

Comments

@vanzod
Copy link

vanzod commented Jun 8, 2017

In the spider output for a hidden module created by hiding the modulefile, the suggested example for detailed information does not include the required --show-hidden flag.

rtmclay pushed a commit that referenced this issue Jun 8, 2017
@rtmclay
Copy link
Member

rtmclay commented Jun 8, 2017

I assume that when doing "module spider b/3.0" and b/3.0 is hidden you want the module load statement to include "--show_hidden". I have updated Lmod to fix this problem. Please test Lmod 7.4.19 to see if it works for you.

@rtmclay
Copy link
Member

rtmclay commented Jun 9, 2017

This is an example of a feature and not a bug. I have removed all the changes I made for 7.4.19 and have released 7.4.20. Note that the source code now in 7.4.20 is the same as 7.4.18.

The spider output was and is:

% module --show_hidden spider b/3.0

------------------------------------------------------------
  b: b/3.0
------------------------------------------------------------

    This module can be loaded directly: module load b/3.0

Even though b/3.0 is a hidden module, it can be loaded w/o the --show_hidden option.
That is the point, you need --show_hidden to show it with avail or spider but a load will find it.
Yes, adding --show_hidden won't break the command. But one of the points of hidden modules is that a user's old job script will load a hidden module without any changes. I don't want users to think that they have to modify old job scripts to load hidden modules.

@rtmclay
Copy link
Member

rtmclay commented Jun 22, 2017

O.K to close?

@rtmclay rtmclay closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants