Merge pull request #169 from Syslifters/168-exportfindings-order

Respect finding order. Fixes #168
Syslifters · Apr 3, 2024 · b07c803 · b07c803
2 parents e06a95b + 0138051
commit b07c803
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 0.17
+* Respect finding order in Project (and exportfindings)
+
 # 0.16
 * Remove locking
 * Strip bogus API token prefix if http header is provided

diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "reptor"
-version = "0.16"
+version = "0.17"
 authors = [
   { name="Richard Schwabe" },
   { name="Aron Molnar", email="[email protected]" }

diff --git a/reptor/models/Project.py b/reptor/models/Project.py
@@ -40,7 +40,8 @@ def __init__(self, data: dict, project_design: ProjectDesign):
         for section in data.get("sections", []):
             self.sections.append(Section(section, project_design))
         # Order findings by their order attribute
-        self.findings.sort(key=lambda f: f.order, reverse=True)
+        if self.override_finding_order:
+            self.findings.sort(key=lambda f: f.order)
 
 
 class ProjectOverview(ProjectBase):