Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convertToIrrev speedup #391

Merged
merged 1 commit into from
Jan 1, 2022
Merged

refactor: convertToIrrev speedup #391

merged 1 commit into from
Jan 1, 2022

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Dec 20, 2021

Main improvements in this PR:

  • refactor:
    • convertToIrrev when converting all reactions to irreversible. This reduces running time of solveLP(model,1) by ~50% on a yeast model.

I hereby confirm that I have:

@github-actions
Copy link

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 Running blastPlusTests . Done blastPlusTests Running cdhitTests . Done cdhitTests Running diamondTests . Done diamondTests Running hmmerTests . Done hmmerTests Running mafftTests . Done mafftTests Running sortIdentifiers_and_permuteModelTests . Done sortIdentifiers_and_permuteModelTests Running tinitTests . Done tinitTests

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk requested a review from simas232 December 31, 2021 10:55
@edkerk edkerk added this to the 2.5.4 milestone Dec 31, 2021
@edkerk edkerk merged commit 2ab6124 into devel Jan 1, 2022
@edkerk edkerk deleted the refactor/solveLP branch January 1, 2022 20:16
@edkerk edkerk mentioned this pull request Jan 13, 2022
4 tasks
@edkerk edkerk restored the refactor/solveLP branch February 10, 2022 00:07
@simas232 simas232 deleted the refactor/solveLP branch March 14, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants