Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: confirm single obj func by checkModelStruct #379

Merged
merged 7 commits into from
Nov 4, 2021
Merged

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Nov 4, 2021

Main improvements in this PR:

  • feat:
    • checkModelStruct confirms whether only one objective function is given, otherwise a warning is thrown (SBML L3V1 FBCv2 only allows 1 objective function) (solves exportModel error #378)
  • fix:
    • exportModel correctly checks for prefixes in model.comps.

I hereby confirm that I have:

@edkerk edkerk added bug Bug that needs fixing. feature A new function or new functionality for an existing function labels Nov 4, 2021
give list of multiple objective functions if existing
@simas232 simas232 added this to the 2.5.4 milestone Nov 4, 2021
@edkerk edkerk merged commit 519d6af into devel Nov 4, 2021
@edkerk edkerk deleted the fix/modelCheck branch November 4, 2021 17:46
@edkerk edkerk mentioned this pull request Jan 13, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that needs fixing. feature A new function or new functionality for an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants