Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revise rxns and GPRs associated with DECR1 and DECR2 #788

Merged
merged 7 commits into from
Dec 27, 2023

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Dec 26, 2023

Main improvements in this PR:

This PR revise reactions and GPRs associated with DECR1 and DECR2

  • remove MAR03322 and MAR03296 due to compartment cofactor mismatch, as reported in DECR1 and DECR2 use NADPH, not NADH #736
    • remove MAR04005, and associated MAM00678c and MAM03035c, due to compartment mismatch
  • sort out GPRs according to compartment localication, as porposed in Localization of DECR1 and DECR2 #755
    • set the GPRs of MAR01176, MAR01181, MAR01218, MAR01222, MAR03446, and MAR03457 to ENSG00000104325
    • set the GPRs of MAR01297, MAR03461, and MAR03471 to ENSG00000242612

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

set GPRs of MAR01176, MAR01181, MAR01218, MAR01222, MAR MAR03446, and MAR03457 to ENSG00000104325
Set the GPRs of MAR01297, MAR03461, and MAR03471 to ENSG00000242612
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good to me; the only note I have is that in the PR message you say MAR03322 and MAR03296 are removed because of a "compartment mismatch", but the problem is that they used the wrong cofactor (NAD instead of NADP), not that they happened in the wrong compartment. Anyway I assume that was a typo, and since you link directly to the relevant issue where the cofactor situation is explained, it's not much of a problem.

@haowang-bioinfo
Copy link
Member Author

All the changes look good to me; the only note I have is that in the PR message you say MAR03322 and MAR03296 are removed because of a "compartment mismatch", but the problem is that they used the wrong cofactor (NAD instead of NADP), not that they happened in the wrong compartment. Anyway I assume that was a typo, and since you link directly to the relevant issue where the cofactor situation is explained, it's not much of a problem.

sorry, that's my mistake and now corrected

@haowang-bioinfo haowang-bioinfo merged commit 8c10adb into develop Dec 27, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/DECR1DECR2_rxnsGPRs branch December 27, 2023 10:00
@JHL-452b JHL-452b mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants