-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revise rxns and GPRs associated with DECR1 and DECR2 #788
Conversation
set GPRs of MAR01176, MAR01181, MAR01218, MAR01222, MAR MAR03446, and MAR03457 to ENSG00000104325
Set the GPRs of MAR01297, MAR03461, and MAR03471 to ENSG00000242612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes look good to me; the only note I have is that in the PR message you say MAR03322
and MAR03296
are removed because of a "compartment mismatch", but the problem is that they used the wrong cofactor (NAD instead of NADP), not that they happened in the wrong compartment. Anyway I assume that was a typo, and since you link directly to the relevant issue where the cofactor situation is explained, it's not much of a problem.
sorry, that's my mistake and now corrected |
Main improvements in this PR:
This PR revise reactions and GPRs associated with DECR1 and DECR2
compartmentcofactor mismatch, as reported in DECR1 and DECR2 use NADPH, not NADH #736I hereby confirm that I have:
develop
as a target branch