Clean up API #5
Merged
Clean up API #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only benefit of /performance over /calculation is the tiny bit of saved serialisation. Not worth the extra api and code complexity. The only benefit of /difficulty over /calculation is avoiding the performance calculation, but performance calc is over 1000x faster than difficulty calculation. The only tangible benefit is when the difficulties have already been calculated and are in the cache, but I still don't think its worth the complexity of the extra api. Can add back later if requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
For an initial release, we should start with the simplest possible friendly API, and add to it as needed, not the other way around.
Changes
/difficultyand/performanceAPI endpoints/calculation)