Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Batch calculations are very naive at the moment.
It effectively is the same process as doing single calculations, but using a single HTTP request.
In the case where there are many hits to the cache/recalculations of the same beatmap/mod, we are wasting a lot of effort.
This PR implement smarter batching by grouping scores by beatmap/mods and processing them in groups to share difficulty calculations.
Changes
Breaking changes
CalculatorService.CalculateDifficultyAttributes
method signature