Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing on missing beatmaps #19

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

Syriiin
Copy link
Owner

@Syriiin Syriiin commented May 18, 2024

Why?

Http 500 errors should be avoided wherever possible.

Changes

  • Throw bad request exception if beatmap not available
  • Check for empty beatmap files on download

@Syriiin Syriiin merged commit de076f1 into master May 18, 2024
2 checks passed
@Syriiin Syriiin deleted the fix/missing-beatmap-crash branch May 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant