Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework] Update arch exclusions for dotnet #5958

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Dec 13, 2023

Description

This pull request enhances the clarity of dotnet 6.x exclusions by revising existing definitions, streamlines the documentation by consolidating notes and history, and introduces specific exclusions for ARMv7 under DSM 6.2.

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Includes small framework changes

@mreid-tt mreid-tt self-assigned this Dec 13, 2023
@mreid-tt
Copy link
Contributor Author

@hgy59, I've created this PR to address the issue in #5909 (comment). Let me know if it has your approval.

@mreid-tt mreid-tt changed the title Framework: Update arch exclusions for dotnet [Framework] Update arch exclusions for dotnet Dec 13, 2023
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreid-tt mreid-tt merged commit e0f3bb2 into SynoCommunity:master Dec 13, 2023
1 check passed
@mreid-tt mreid-tt deleted the framework-archs-update branch December 13, 2023 21:32
@hgy59
Copy link
Contributor

hgy59 commented Dec 13, 2023

@mreid-tt one point remaining:

Since armv7 on DSM 6 is not supported for dotnet, I am almost sure that comcerto2k-7.1 is not suppported too.

We have several packages that support armv7 on DSM 7 but do not support comcerto2k.
The comcerto2k toolchain did not get glibc and gcc updates on DSM 7 but other arm7 archs did. That was the reason we need to build comcerto2k-7.1 differently to armv7-7.1 (on DSM 6 comcerto2k was included in the generic armv7 builds, but for DSM 7 we had to split comcerto2k out of generic armv7 builds).

The only model with comcerto2k arch is DS414j.
So to validate whether packages built with dotnet core are supported on comcerto2k with DSM 7, we need feedback from users having still a DS414j running.

related issues #5111, #4871, #3453

@mreid-tt I guess you did not get feedback for comcerto2k in #5574. So I propose to add comcerto2k-7.1 to UNSUPPORTED_ARCHS_TCVERSION (for both DOTNET_CORE_ARCHS and DOTNET_SERVARR_ARCHS).

If ever a user will complain a missing comcerto2k package, we will have a chance to build and test it.

what do you think?

@hgy59
Copy link
Contributor

hgy59 commented Dec 13, 2023

oops it took too long to write the comment above...

mreid-tt added a commit to mreid-tt/spksrc that referenced this pull request Jan 15, 2024
mreid-tt added a commit that referenced this pull request Jan 15, 2024
* Update to v0.3.14.2358
* Fix armv7 arch exclusions (amends PR #5958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants