Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Update dotnet 6.0 exclusions #5680

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Mar 29, 2023

Description

This is a follow-on from #5602 and adds the exclusions for alpine and alpine4k based on investigation in #5302 (comment) and #5574 (comment).

Fixes #
Closes #4528
Closes #5302
Closes #4546

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@mreid-tt mreid-tt added framework dotnet Related to dotnet (core) labels Mar 29, 2023
@mreid-tt
Copy link
Contributor Author

@hgy59, further testing with alpine confirms incompatibility with dotnet 6 running on DSM 7.

I was wondering, given that we are updating the version of mono to v6 soon do we think this is a path to supporting the various *arr packages on older platforms? I know that Jackett for example has a mono build that is used for these older platforms but I wonder if we can do the same for the *arr packages? Would it be possible to compile a mono build for them?

@hgy59
Copy link
Contributor

hgy59 commented Mar 30, 2023

So finally are the only 32 bit ARM archs with support for dotnet armada375 and armada38x ?
If so, I doubt that it is worth to do all this work for exclusion.

We could simply declare ARMv7 (the generic one) as unsupported and create dedicated packages for the two remaining archs.

Or we use ARMv7 for the packages with mono dependency and exluce armada375 and armada38x in this generic package (we have the Makefile variable REMOVE_FROM_GENERIC_ARCHS to do so).

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Mar 30, 2023

Checking the earlier tests we have support for armada375, armada38x, armadaxp and monaco under DSM 7. I don't know if this changes things.

EDIT: I think that comcerto2k should be supported as well but I know that's built separately.

I was looking at the Makefile variables page and I didn't see the REMOVE_FROM_GENERIC_ARCHS variable listed.

@mreid-tt mreid-tt merged commit 1dd97ac into SynoCommunity:master Apr 2, 2023
@mreid-tt mreid-tt deleted the framework-archs-update branch April 2, 2023 17:35
@mreid-tt mreid-tt self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Related to dotnet (core) framework
Projects
None yet
2 participants