-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono: fix DSM 7 compatibility #5604
Conversation
@hgy59, I did a clean install as well as an upgrade install and tested Sonarr v3 in each case. All the logs looked clean as follows:
For the testing with Sonarr v3 both scenarios were successful in that the certificate errors were not encountered. |
Good work! Are you sure that is the correct followup PR you mention? I'll test it out over the weekend |
Thanks. This PR follows on the last merge into the repository. It does necessarily change something there but it was in that PR that I realised that the original issues (#5051, #5354) were in fact fixed. Based on discussion with @hgy59 in #5522 (comment) and #5522 (comment) it seems that something was previously broken in the framework and the last published version did not correctly apply the patch to relocate special folders. In that conversation he also pointed out that the |
@hgy59, is this good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
we only have to keep in mind, that aarch64-6.1 must not be published due to the known error with ECC.
No need to remember, I've included the exclusion in the Makefile with a reference to the originating issue. |
@hgy59, when this is published I would suggest removing v5.20.1.34-18 as that version was known to have the issue applying the patch to relocate special folders (I've already confirmed that v5.20.1.34-17 was good). |
I have deleted all earlier 5.20 versions. |
Description
This PR is to update the patch files to use
/var/packages/mono/var
instead of/var/packages/mono/target/var
for DSM 7 compatibility.Follow up of #5522
Supersedes #5070
Fixes #5051, #5354
Checklist
all-supported
completed successfullyType of change