Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: update to v7.87 and add optional features #5543

Merged
merged 20 commits into from
Jan 19, 2023

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Dec 29, 2022

Description

update curl to v7.87.0

avoid blowing up cross/curl with additional features (introduced with #5495 for tvheadend)

  • add BUILD_CURL_WITH variable to build optional features (libssh2, gnutls, mbedtls)
  • avoid the optional features for all dependent packages as those are currently used with tvheadend only
  • update tvheadend to build curl with features as before
  • add diyspk/curl/Makefile to build curl with all features

- add BUILD_CURL_WITH variable to build optional features (libssh2, gnutls, mbedtls)
- avoid the optional features for all dependent packages as those are currently used with tvheadend only
- update tvheadend to build curl with features as before
- add diyspk/curl/Makefile to build curl with all features
@th0ma7
Copy link
Contributor

th0ma7 commented Dec 30, 2022

This is a neat idea. If you need i can review it over the weekend.

@hgy59 hgy59 requested a review from th0ma7 December 30, 2022 09:57
- update mbedtls to v2.28.2
- add zlib support for mbedtls
@hgy59 hgy59 changed the title add optional features to cross/curl curl: update to v7.78 and add optional features Dec 30, 2022
@hgy59 hgy59 changed the title curl: update to v7.78 and add optional features curl: update to v7.87 and add optional features Dec 30, 2022
- optional build curl with websockets (this feature is experimental)
- optional build curl with libidn2
cross/tvheadend/Makefile Outdated Show resolved Hide resolved
- update openldap to v2.6.3
- make binary files optional (use OPENLDAP_INCLUDE_EXECUTABLES to include executables)
- add option to build curl with libpsl
- add option to build curl with nghttp2
- add option to build curl with gsasl
- add option to build curl with gss (gssapi)
- add option to build curl with ldap (OpenLDAP)
- use c-ares as asynch dns resolver
- add patch for older gcc
- add GNUTLS_INCLUDE_EXECUTABLES variable to optionally include executable files
Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Your proposal for adding functionality to curl is really neat.

Two proposed changes:

  1. Removing websocket entirly from TVH
  2. Moving zstd as BUILD_CURL_WITH option

cross/tvheadend/Makefile Outdated Show resolved Hide resolved
cross/tvheadend/Makefile Outdated Show resolved Hide resolved
hgy59 added 3 commits January 4, 2023 06:08
- add zstd to optional features
- add brotli as optional feature
@hgy59
Copy link
Contributor Author

hgy59 commented Jan 4, 2023

@th0ma7 this is now ready to merge

I did not succeed to add the optional protocol RTMP as librtmp from rtmpdump is not prepared for cross compilation

@hgy59 hgy59 merged commit 7b46949 into SynoCommunity:master Jan 19, 2023
@hgy59 hgy59 deleted the curl_features branch January 19, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants