Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg 4.2.3 + dependencies update #3965

Merged
merged 48 commits into from
May 29, 2020
Merged

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Apr 20, 2020

Motivation: Preparation work for next version of ffmpeg.
Linked issues: None currently.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Changes

  • Update of x265 to version 3.3
  • Update of x264 to latest stable snapshot
  • Update of Intel libva and libva-utils to version 2.7.1
  • Update of Intel gmmlib to 20Q1 version 20.1.1
  • Update of Intel Media Driver to 20Q1 version 20.1.1
  • Update of Intel Media SDK to 20Q1 version 20.1.1
  • Update of libogg to version 1.3.4
  • Update of fribidi to version 1.0.9
  • Update of libbluray to version 1.2.0
  • Update of libaom to tag v2.0.0-rc1
  • Update of freetype to version 2.10.2
  • Update of utils-linux to version 2.35
  • Add experimental svt-av1 support version 0.8.3 (64-bit arches only)
  • Add experimental svt-hevc support version 1.4.3 (x86_64 Intel arches only)
  • Add +setuid to vainfo binary for ease of use

Issues fixed upstream:

Locally patched issues:

@th0ma7 th0ma7 changed the title ffmpeg next [WIP] ffmpeg next May 15, 2020
@th0ma7 th0ma7 mentioned this pull request May 22, 2020
3 tasks
@th0ma7 th0ma7 changed the title [WIP] ffmpeg next ffmpeg 4.2.3 + dependencies update May 22, 2020
@th0ma7 th0ma7 requested review from ymartin59 and hgy59 May 22, 2020 13:33
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some minor request improvements.

cross/svt-av1/digests Outdated Show resolved Hide resolved
cross/svt-av1/Makefile Show resolved Hide resolved
cross/svt-hevc/digests Outdated Show resolved Hide resolved
cross/svt-hevc/Makefile Show resolved Hide resolved
Comment on lines 11 to 16
service_postupgrade ()
{
# setuid for proper vaapi access
chmod u+s /var/packages/ffmpeg/target/bin/ffmpeg
chmod u+s /var/packages/ffmpeg/target/bin/vainfo
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://help.synology.com/developer-guide/synology_package/scripts.html service_postupgrade may be discarded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for now it still stands, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is harmless but also useless as postinst is called by postupgrade during upgrade sequence.

@th0ma7 th0ma7 requested a review from ymartin59 May 28, 2020 23:43
@ymartin59 ymartin59 merged commit 74d8a1e into SynoCommunity:master May 29, 2020
@ymartin59
Copy link
Contributor

@th0ma7 Thanks. Merged. You can go on with CMake support!

@th0ma7
Copy link
Contributor Author

th0ma7 commented May 29, 2020

Thnx, next on my todo list!

@th0ma7 th0ma7 deleted the ffmpeg-next branch May 29, 2020 09:30
@th0ma7 th0ma7 mentioned this pull request Jul 4, 2020
11 tasks
@th0ma7 th0ma7 linked an issue Aug 14, 2020 that may be closed by this pull request
@EngMarc
Copy link

EngMarc commented Jun 13, 2021

Just upgraded to DSM 7.0 so checking for ffmpeg compatibility. I had dl’d the build from the community site but this doesn’t work on DSM 7.0.
Ideas?
I’m going to do some searching

@EngMarc
Copy link

EngMarc commented Jun 13, 2021

Here’s the error basically says ‘Incompatible file format’

Screen Shot 2021-06-13 at 17 42 08

@hgy59
Copy link
Contributor

hgy59 commented Jun 13, 2021

you might find the error cause in the file /var/log/messages

but as you can see in #4524 ffmpeg is not yet published for DSM7
and look in Readme for DSM7 (in the synocommunity repo we cannot disable packages for DSM7 when not compatible with DSM7).

@EngMarc
Copy link

EngMarc commented Jun 14, 2021

Thanks, I did check the /var/log/messages file. There’s a few errors that videostation erroring out trying generate what looks like thumbnails at first glance. Then, when I do the ffmpeg repair that generates the above error I get this. Not sure it’s related but doing a tail -f on the messages file watching as I try to ‘repair’ the ffmpeg gens the below log messages.

2021-06-14T04:09:07-05:00 DiskStation sscamerad[5957]: SYSTEM: Last message 'ssdebuglog.cpp:226:S' repeated 10043 times, suppressed by syslog-ng on DiskStation
2021-06-14T04:09:07-05:00 DiskStation sscamerad[7733]: ssdebuglog.cpp:226:SSVPrintf(): open sslog file failed with errno [24].
2021-06-14T04:09:07-05:00 DiskStation sscamerad[7733]: ssdebuglog.cpp:226:SSVPrintf(): open sslog file failed with errno [24].
2021-06-14T04:09:07-05:00 DiskStation sscamerad[7733]: ssdebuglog.cpp:226:SSVPrintf(): open sslog file failed with errno [24].

@ymartin59
Copy link
Contributor

Please do not comment on old+merged PR... just create a new issue with reference to PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libshine not enabled with ffmpeg
4 participants