Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg-videostation: divert ffmpeg to SynoCommunity version #3828

Closed

Conversation

ymartin59
Copy link
Contributor

Motivation: Ease use of SynoCommunity ffmpeg version in VideoSation.
Linked issues: #2952

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@ymartin59
Copy link
Contributor Author

@th0ma7 I quickly build this for me to test ffmpeg patches... as I have some mkv VideoStation fails to play too.

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 21, 2019

Good, have a look at my latest -18 build in my github repo.
I think I have nailed most of the issues but ffmpeg is a heck of a beast.
What mainly missing are testing files everyone could use for proper testing along with various ways of testing things out, with and without videostation.

Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed command will break the library on main 10 due to missing character.
Also I recommend creating a backup file through a one-liner command such as:

$ sudo  sed -i'-BACKUP' -e 's/eac3/ZAAP/' -e 's/dts/ZAP/' -e 's/truehd/ZAPZAP/' -e 's/main 10/ZAAAAAP/' /var/packages/VideoStation/target/lib/libsynovte.so

@kc6108
Copy link

kc6108 commented Dec 22, 2019

main 10 wouldn't be found anyway; it's Main 10. It's also 7 characters long, so IGNORE should be changed to IGNORED perhaps.

See my comments here:

#2952 (comment)

Edit...

For consistency, in stop_daemon (), maybe add:

rm /var/packages/VideoStation/target/lib/libsynovte.so

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 23, 2019

Along with a move or copy of libsynovte.so-BACKUP into it's original place in stop_daemon ()

@ymartin59
Copy link
Contributor Author

@th0ma7 Your sed proposal is a concise good idea I will give it a try

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 24, 2019

Maybie also appropriate to use a wrapper instead of symlinks such as:
https://gist.github.com/BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 25, 2019

Created a new wrapper that does fix the spawning of multiple ffmpeg processes:
https://github.com/th0ma7/synology/blob/master/VideoStation/ffmpeg
I'll have it tested by the community and if working out well then we could include it to this package.

@th0ma7
Copy link
Contributor

th0ma7 commented Dec 31, 2019

Totally untested but I had a few ideas I wanted to share. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants