Implement type mapping for VectorType

[wilsonk]

I ran into the need for this when trying to build an opencv example. Now I am running into an operator overload problem (same error for zeromq and a couple STL examples), so it seems that fixing operator overloading is the most pressing matter now.

[Syniurge]

Hi Kelly,

The mapping is incorrect, VectorType and ExtVectorType are never sugared:

http://clang.llvm.org/doxygen/Type_8h_source.html#l02600
http://clang.llvm.org/doxygen/Type_8h_source.html#l02682

And more importantly you should be returning a TypeVector. The TypeVector constructor expects a TypeSArray as argument, look into mtype.h/cpp for more details.

[wilsonk]

Hey Elie,

Geez, I should actually look at the D side of this more. I just figured since fromType worked here then things were being mapped fine. Didn’t even think to check if isSugared would return only false.

I also wrote a couple tests this time to make sure things worked instead of just assuming. Seems to compile and work now. We get a runtime error on the D side if the C++ vector type is too big, at least.

Thanks,

Kelly

From: Elie Morisse [mailto:[email protected]]
Sent: Tuesday, April 14, 2015 5:35 PM
To: Syniurge/Calypso
Cc: wilsonk
Subject: Re: [Calypso] Implement type mapping for VectorType (#9)

Hi Kelly,

The mapping is incorrect, VectorType and ExtVectorType are never sugared:

http://clang.llvm.org/doxygen/Type_8h_source.html#l02600
http://clang.llvm.org/doxygen/Type_8h_source.html#l02682

And more importantly you should be returning a TypeVector. The TypeVector constructor expects a TypeSArray as argument, look into mtype.h/cpp for more details.

—
Reply to this email directly or view it on GitHub #9 (comment) .

[Syniurge]

Merged manually after squashing, and oddly the PR didn't pick up so I'm closing it.