Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module deprecation missing on VM #552

Closed
evgueni-ovtchinnikov opened this issue Feb 19, 2020 · 4 comments
Closed

Module deprecation missing on VM #552

evgueni-ovtchinnikov opened this issue Feb 19, 2020 · 4 comments
Assignees

Comments

@evgueni-ovtchinnikov
Copy link
Contributor

Running ctest on VM got no module named deprecation error. Had to do sudo pip istall deprecation.

@KrisThielemans
Copy link
Member

This is a VM issue. Please file in approriate place.

However, this has been addressed by @paskino in SyneRBI/SyneRBI_VM#143. I believe I also asked to put this in our installation instructions. Not sure if that happened.

More worrying is why we need it.

@rijobro
Copy link
Contributor

rijobro commented Feb 20, 2020

Apologies, I added it in #497, where I wanted to deprecate process in favour of forward/back/direct/adjoint. I can remove it if it's causing too much hassle.

@KrisThielemans
Copy link
Member

if it serves a purposes, it's fine of course. Should be added to our list of required Python modules.

I suggest we do that by addressing #124. Seems a 5 minute job to copy the list into that file. Then in the install instructions we just link to the file. Later on, in the VM, we use it to pip install.

KrisThielemans added a commit to KrisThielemans/SIRF that referenced this issue Feb 23, 2020
Uses new facility to set SIRF_SOURCE_DIR

Fixes SyneRBI#559
Partially addresses SyneRBI#552
@evgueni-ovtchinnikov
Copy link
Contributor Author

VM now has deprecation, so closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants