-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated modules in find_package command for Python3 #933
base: master
Are you sure you want to change the base?
Conversation
https://cmake.org/cmake/help/latest/module/FindPythonInterp.html deprecated since 3.12, while we require 3.16.2. Current change is minimal. We probably should pass |
Need to update how we look for cython I guess
This error is different from why I saw in #932 but it's possible that @NicoleJurjew only saw the Tomophantom error when using this branch I guess. |
With the suggested changes, the PYTHONPATH isn't exported correctly. I think some changes need to be done here, as well: |
that's a bit strange. What is the content of env_sirf.sh etc then? Can you just do a message(STATUS "PYTHON_EXECUTABLE=${PYTHON_EXECUTABLE}") before those statement to check what it is? |
No description provided.