[TRAVIS] fix DEVEL_BUILD

[KrisThielemans]

required for recent Gadgetron

[KrisThielemans]

@casperdcl how do we switch the docker devel build to use gcc6?

[KrisThielemans]

something wrong in our Travis file as it ignores the CC=gcc-6 settings. Checking a log I find

$ export EXTRA_BUILD_FLAGS="-DDEVEL_BUILD=ON -DUSE_SYSTEM_Boost=OFF -DUSE_SYSTEM_FFTW3=OFF -DUSE_SYSTEM_HDF5=OFF -DUSE_SYSTEM_SWIG=OFF"
$ export CC=gcc-6
$ export CXX=g++-6
$ export PYMVER=2

$ export TRAVIS_COMPILER=g++
$ export CXX=g++
$ export CXX_FOR_BUILD=g++
$ export CC=gcc
$ export CC_FOR_BUILD=gcc

Anyone? @casperdcl ?

[paskino]

I used to set CMAKE_CXX_COMPILER and CMAKE_C_COMPILER variables issuing CMake on our cluster to get it pick the right compiler.

[paskino]

First, I don't find where this variables are set.

However in the .travis.yml I see

addons:
      apt:
        sources:
         - ubuntu-toolchain-r-test
        packages:
            - g++-6

which seems to imply that we install the g++-6 package from ubuntu-toolchain-r-test. I do not find that package at their website, only gcc-6. Maybe I'm totally wrong.

At any rate the gcc-6 package does not contain a binary g++-6.

[paskino]

On my 16.04 VM

sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-cache search g++-6

> clang-6.0 - C, C++ and Objective-C compiler
> clang-6.0-doc - C, C++ and Objective-C compiler - Documentation
> clang-6.0-examples - Clang examples
> libclang-6.0-dev - clang library - Development package
> python-clang-6.0 - Clang Python Bindings

[KrisThielemans]

I have no idea about the toolchain-r, but g++-6 is installed ok. we can even get g++-8 there. you can see it in the log (link above).

The problem is just the setting of the environment variables in Travis. we set them for each configuration (e.g. here, as the compilers are different for each config. That's ok as you can see in the log and my quote in the first post. However, then Travis overrides them with something else, presumably because of how our yml file is. (We needed to set the config to python to get that side to work).

[KrisThielemans]

@paskino, please revert this /82b09356a52acafd75bb6333a141b8f9bfbe4146 commit.

NOT all configs use gcc6. we will want to be able to use different compilers.

Also, using the CMake flags doesn't transport to boost, fftw etc, see #14.

[paskino]

Of course, but how would I check if the changes work?

[KrisThielemans]

how would I check if the changes work?
the issue is not if the code compiles with gcc6 (we're quite confident that it does). The question is how to convince travis to set the right env variables or whatever

Have a look at travis-ci/travis-ci#5293

[KrisThielemans]

remaining failures are due to a problem with Gadgetron master gadgetron/gadgetron#715

[casperdcl]

just to note that only 2 docker images are built: standard and devel (ubuntu 16.04, gcc5)

see default flags here: https://github.com/CCPPETMR/SIRF-SuperBuild/blob/c3a2c065e3ff0358b8b2c3dbf9961268b2f03cc0/docker/Dockerfile#L78-L82