Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Various Quest Issues #1281

Merged
merged 14 commits into from
Feb 11, 2025
Merged

Conversation

littlecube8152
Copy link
Contributor

@littlecube8152 littlecube8152 commented Feb 3, 2025

What

This PR will fix the following issues in the quest book:

Implementation Details

Steam Age Quests

  • Quest 46 (H2SO4): The drums are removed from the quest, and description is changed.
  • Quest 62 (Double barrel shotgun): The recipes are changed. The only recipe for steel barrel seemed to be wrong. The new recipe is introduced to fix them.
  • Quest 79 (Wiring 101): The task logic is changed to OR so fine wire (which is the one require for that progression) can complete the quest
  • Quest 437 (Multiblock help): The overlength description on the link button is separated.
  • Quest 666 (Ghost circuit): It is now both present in steam age and LV age. However, the dependency from start of LV age is removed to prevent cyclic dependencies.

LV Age Quests

  • Quest 385 (Explosives): The logic is changed to OR, so any explosive will complete the quest. The description did mention that "most" of the chemistry is available, so the HV one (incendiary explosives) is still kept.
  • Quest 646 (LV item magnet): The extra one in steam age tab is removed. The remaining one is in the LV tab (after polarizer).

Power Gen Quests

  • Quest 790 (Syngas): Proper icon and added both possible power generation synthetic gas as tasks. The logic is OR.

Rubylith Quests

  • Quest 1766408250 is moved to ID 887
  • Many dependencies changed according to the recipes.
  • A new quest for methanol is added, including related dependencies updated.
  • Several quests has minor description changes, mostly statement colorization and bug fixes.

OpenComputer Quests

  • The start of OpenComputer quests is moved to after wafer plates (that is, after rubylith) since tier 1 computer already requires integrated circuit wafer plates.
  • Analyzer and cables are changed to more like a side quest. They no longer block the quest progression.

Oil Quests

  • Descriptions are updated.
  • Layout is also changed.

Outcome

Fixes the issues listed above.

Additional Information

Potential Compatibility Issues

QB should be reloaded afterwards. Thorough testing should be performed as ill-formed quests can actually corrupt the save (why?)

@littlecube8152 littlecube8152 marked this pull request as ready for review February 4, 2025 09:14
@bruberu
Copy link
Member

bruberu commented Feb 5, 2025

Very good! I just have the three below comments:

  • kovar is currently dependent on the alloy smelter, when it technically only is gated by the EBF
  • additionally, I'm not sure how OC quests are now moved to be after rubylith; the only dependency I see is on the chapter 3 (MV) open
  • move up bottom row of oil processing quests

@littlecube8152
Copy link
Contributor Author

These have been fixed in the latest commit, where

  • Kovar dependency is fixed (now only depends on nickel)
  • OC quests have added the correct dependency. The change is because the Tier 1 computer requires integrated circuit:
    Screenshot from 2025-02-05 13-32-05
    Screenshot from 2025-02-05 13-32-14
  • Oil quests are now aligned

@littlecube8152
Copy link
Contributor Author

I seemed to overlook the nitrobenzene --> aniline is not possible part. I will rework the quest.

@littlecube8152
Copy link
Contributor Author

Now it is fixed. It seems that HV machines are obtainable before rubylith so basically, players can do distillation first if they wan. As a result, the quest is technically not wrong, but I have added pyridine route for aniline quest, and B.T.E.X. for benzene and xylene.

@trainvoi
Copy link
Collaborator

trainvoi commented Feb 9, 2025

revert changes to these files:
image

@littlecube8152
Copy link
Contributor Author

revert changes to these files: image

Fixed, sorry for that

Copy link
Member

@bruberu bruberu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's goode

@bruberu bruberu merged commit c9e3bfc into SymmetricDevs:master-ceu Feb 11, 2025
@littlecube8152 littlecube8152 deleted the quest-fix branch February 16, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants