Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] UriSigner to become internal in 2.x #165

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[1.x] UriSigner to become internal in 2.x #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebdbbf2
[1.x] UriSigner to become internal in 2.x
jrushlow Mar 12, 2024
986508f
start an upgrade guide for 2.0
jrushlow Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Upgrade from 1.x to 2.0

## UriSignerFactory

- The `UriSignerFactory` became `@internal` & `@final`. This class should not be
used.
18 changes: 11 additions & 7 deletions src/Factory/UriSignerFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,20 @@
/**
* @author Victor Bocharsky <[email protected]>
* @author Ryan Weaver <[email protected]>
*
* Will become final && internal and ultimately removed in v2.0.
*
* @internal
*
* @final
*/
class UriSignerFactory
{
private $secret;
private $parameter;

public function __construct(string $secret, string $parameter = '_hash')
{
$this->secret = $secret;
$this->parameter = $parameter;
public function __construct(
#[\SensitiveParameter]
private string $secret,
private string $parameter = '_hash'
) {
}

/**
Expand Down
Loading