Skip to content

Commit

Permalink
feature #165 [1.x] UriSigner to become internal in 2.x
Browse files Browse the repository at this point in the history
* [1.x] UriSigner to become internal in 2.x

* start an upgrade guide for 2.0
  • Loading branch information
jrushlow authored Mar 14, 2024
1 parent d60e9e8 commit e44ebca
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
6 changes: 6 additions & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Upgrade from 1.x to 2.0

## UriSignerFactory

- The `UriSignerFactory` became `@internal` & `@final`. This class should not be
used.
18 changes: 11 additions & 7 deletions src/Factory/UriSignerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,20 @@
/**
* @author Victor Bocharsky <[email protected]>
* @author Ryan Weaver <[email protected]>
*
* Will become final && internal and ultimately removed in v2.0.
*
* @internal
*
* @final
*/
class UriSignerFactory
{
private $secret;
private $parameter;

public function __construct(string $secret, string $parameter = '_hash')
{
$this->secret = $secret;
$this->parameter = $parameter;
public function __construct(
#[\SensitiveParameter]
private string $secret,
private string $parameter = '_hash'
) {
}

/**
Expand Down

0 comments on commit e44ebca

Please sign in to comment.