Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate raw for pretty #109

Merged
merged 1 commit into from
Nov 2, 2024
Merged

feat: deprecate raw for pretty #109

merged 1 commit into from
Nov 2, 2024

Conversation

MilesCranmer
Copy link
Member

No description provided.

@MilesCranmer MilesCranmer merged commit d5fab73 into master Nov 2, 2024
12 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11645363811

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 95.32%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Strings.jl 6 7 85.71%
Totals Coverage Status
Change from base Build 11645024188: -0.03%
Covered Lines: 2424
Relevant Lines: 2543

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Benchmark Results

master fef28bf... master/fef28bf3d225b6...
eval/ComplexF32/evaluation 7.27 ± 0.59 ms 7.23 ± 0.53 ms 1.01
eval/ComplexF64/evaluation 10.7 ± 0.9 ms 10.7 ± 0.92 ms 0.999
eval/Float32/derivative 11.9 ± 0.99 ms 11.7 ± 0.91 ms 1.02
eval/Float32/derivative_turbo 11.9 ± 1 ms 11.6 ± 0.92 ms 1.02
eval/Float32/evaluation 2.74 ± 0.26 ms 2.72 ± 0.25 ms 1.01
eval/Float32/evaluation_bumper 0.605 ± 0.015 ms 0.602 ± 0.013 ms 1
eval/Float32/evaluation_turbo 0.555 ± 0.034 ms 0.576 ± 0.038 ms 0.963
eval/Float32/evaluation_turbo_bumper 0.605 ± 0.014 ms 0.602 ± 0.014 ms 1.01
eval/Float64/derivative 15 ± 0.61 ms 14.8 ± 0.61 ms 1.02
eval/Float64/derivative_turbo 15.1 ± 0.67 ms 14.8 ± 0.56 ms 1.02
eval/Float64/evaluation 3.21 ± 0.31 ms 3.15 ± 0.3 ms 1.02
eval/Float64/evaluation_bumper 1.26 ± 0.045 ms 1.26 ± 0.043 ms 0.995
eval/Float64/evaluation_turbo 1.04 ± 0.068 ms 1.04 ± 0.067 ms 0.994
eval/Float64/evaluation_turbo_bumper 1.26 ± 0.045 ms 1.26 ± 0.042 ms 1
utils/combine_operators/break_sharing 0.0389 ± 0.0005 ms 0.0387 ± 0.00045 ms 1
utils/convert/break_sharing 27.3 ± 3.1 μs 26.2 ± 2.9 μs 1.04
utils/convert/preserve_sharing 0.0971 ± 0.0031 ms 0.097 ± 0.004 ms 1
utils/copy/break_sharing 28 ± 3.1 μs 27.1 ± 2.8 μs 1.03
utils/copy/preserve_sharing 0.0984 ± 0.0033 ms 0.0998 ± 0.0044 ms 0.987
utils/count_constant_nodes/break_sharing 8.83 ± 0.18 μs 8.57 ± 0.17 μs 1.03
utils/count_constant_nodes/preserve_sharing 0.0852 ± 0.003 ms 0.0848 ± 0.0034 ms 1
utils/count_depth/break_sharing 9.71 ± 0.21 μs 9.88 ± 0.21 μs 0.983
utils/count_nodes/break_sharing 8.93 ± 0.17 μs 8.39 ± 0.16 μs 1.06
utils/count_nodes/preserve_sharing 0.0852 ± 0.0031 ms 0.0846 ± 0.0031 ms 1.01
utils/get_set_constants!/break_sharing 0.0332 ± 0.0017 ms 0.0328 ± 0.0021 ms 1.01
utils/get_set_constants!/preserve_sharing 0.174 ± 0.005 ms 0.179 ± 0.0055 ms 0.972
utils/get_set_constants_parametric 0.0451 ± 0.0021 ms 0.0449 ± 0.0022 ms 1.01
utils/has_constants/break_sharing 4.13 ± 0.14 μs 4.2 ± 0.13 μs 0.984
utils/has_operators/break_sharing 2.01 ± 0.055 μs 2.26 ± 0.067 μs 0.89
utils/hash/break_sharing 22.7 ± 0.48 μs 23.2 ± 0.66 μs 0.978
utils/hash/preserve_sharing 0.096 ± 0.0032 ms 0.0975 ± 0.0037 ms 0.985
utils/index_constant_nodes/break_sharing 24.9 ± 0.98 μs 25 ± 1.1 μs 0.994
utils/index_constant_nodes/preserve_sharing 0.0967 ± 0.0029 ms 0.0972 ± 0.0034 ms 0.995
utils/is_constant/break_sharing 5.04 ± 0.12 μs 4.08 ± 0.13 μs 1.24
utils/simplify_tree/break_sharing 0.18 ± 0.0031 ms 0.171 ± 0.0028 ms 1.05
utils/simplify_tree/preserve_sharing 0.23 ± 0.0066 ms 0.217 ± 0.0051 ms 1.06
utils/string_tree/break_sharing 0.473 ± 0.014 ms 0.477 ± 0.015 ms 0.991
utils/string_tree/preserve_sharing 0.578 ± 0.017 ms 0.584 ± 0.019 ms 0.989
time_to_load 0.204 ± 0.0044 s 0.203 ± 0.0045 s 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants