Add new colab notebook for AdalFlow data class implementation #226
Conversation
ajithvcoder
changed the title
|
@liyin2015 let me know if the notebook is fine |
| @@ -0,0 +1,794 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #5. box_office: Optional[float] = field(
No need to use Optional. As any field in dataclass that comes with default or default_factory is an optional field. Sometimes using Optional will confuse the LLM or unable to support complicated data structure
Reply via ReviewNB
There was a problem hiding this comment.
i have addressed the issue
| @@ -0,0 +1,794 @@ | |||
| { | |||
There was a problem hiding this comment.
Try to use <USER></USER> to replace User: This fits more on how LLMs are using special tokens
Reply via ReviewNB
There was a problem hiding this comment.
i have addressed the issue
|
@ajithvcoder This is great work to show more complicated dataclass structure. I have left comments and basically need to add "No optional" in the dataclass. And please adjust to this new info and rerun the test again. And then it should be good to go! Also, please rebase to the main as the current base failed on tests |
|
@liyin2015 @Sylph-AI i will do the required changes but it wont pass the ci/cd because there is no quotes here . i have addressed similar issues in this pr #227 . |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@liyin2015 i have made the changes kindly review, its a single file which is not in Adalflow/main branch so i didnt rebase it. Also it has successfully passed the checks |
|
found a method for rebasing and i have rebased it also |
Added a new notebook for dataclass tutorial based on following issues