Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch Sylius 1.13 branch 🚀 #949

Merged
merged 18 commits into from
Feb 28, 2024
Merged

Launch Sylius 1.13 branch 🚀 #949

merged 18 commits into from
Feb 28, 2024

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Feb 12, 2024 •
edited
Loading

Preparation of Sylius-Standard to support Sylius 1.13

@Rafikooo Rafikooo requested a review from a team as a code owner February 12, 2024 14:32
@Rafikooo Rafikooo force-pushed the support-sylius-1.13-alpha-version branch from 1111820 to 4a137e8 Compare February 16, 2024 09:56
@Rafikooo Rafikooo changed the base branch from 1.12 to 1.13 February 16, 2024 09:57
@probot-autolabeler probot-autolabeler bot added the Docker Docker-related issues and PRs. label Feb 16, 2024
@Rafikooo Rafikooo changed the title [Maintenance] Support Sylius 1.13 alpha.1 Launch Sylius 1.13 branch : Feb 16, 2024
@Rafikooo Rafikooo changed the title Launch Sylius 1.13 branch : Launch Sylius 1.13 branch 🚀 Feb 16, 2024
@Rafikooo Rafikooo changed the title Launch Sylius 1.13 branch 🚀 Launch Sylius 1.13 branch 🚀 Feb 16, 2024
@Rafikooo Rafikooo force-pushed the support-sylius-1.13-alpha-version branch from 0f030f6 to 39feb37 Compare February 16, 2024 11:07
@diimpp
Copy link
Member

diimpp commented Feb 20, 2024

Would be cool to merge #650 before that. PR requires rebase

@Rafikooo
Copy link
Contributor Author

Would be cool to merge #650 before that. PR requires rebase

@diimpp,
Thank you for being proactive. We have talked about this and decided to move to attributes in Sylius 2.0. This decision was made because some of our plugin vendors have not yet updated to work with attributes, and we want to avoid causing their life harder in 1.x version

@Rafikooo Rafikooo force-pushed the support-sylius-1.13-alpha-version branch 4 times, most recently from 3973670 to da89df9 Compare February 23, 2024 17:19
@Rafikooo Rafikooo force-pushed the support-sylius-1.13-alpha-version branch from da89df9 to 6524949 Compare February 23, 2024 17:39
@Rafikooo Rafikooo force-pushed the support-sylius-1.13-alpha-version branch from 6524949 to 8b25b44 Compare February 23, 2024 17:59
@TheMilek TheMilek merged commit 3ee13e7 into Sylius:1.13 Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@Wojdylak Wojdylak Wojdylak approved these changes

@TheMilek TheMilek TheMilek approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Docker Docker-related issues and PRs. Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rafikooo @diimpp @NoResponseMate @Wojdylak @TheMilek @jakubtobiasz