Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker]Keep the Gulp in the docker and prepare proper migration #833

Closed
wants to merge 1 commit into from

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Oct 3, 2022

As we are going to support both GULP and WebPack in Sylius 1.12 we should do the same in Docker containers. I reverted some of the changes from #831 PR because the main branch docker is broken.

Let's make a step back and prepare the node container for webpack and for gulp.

FYI: #832

@probot-autolabeler probot-autolabeler bot added the Docker Docker-related issues and PRs. label Oct 3, 2022
@Ferror Ferror changed the title [docker] [docker]Keep the Gulp in the docker and prepare proper migration Oct 3, 2022
@Ferror Ferror marked this pull request as ready for review October 3, 2022 20:12
@Ferror Ferror requested a review from a team as a code owner October 3, 2022 20:12
@Ferror
Copy link
Contributor Author

Ferror commented Oct 3, 2022

F. it. The webpack is required.

@Ferror Ferror closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker-related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant