Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiFilter raises StopIteration #82

Closed
wants to merge 1 commit into from
Closed

Conversation

shroom00
Copy link

MultiFilter raises StopIteration if there are no tokens to filter. Added a check for this case and returned an empty token list.

Description

  • relevant motivation: I ran into this error when parsing queries (that should've been null queries) with a custom tokeniser.
  • a summary of the change: See above.
  • which issue is fixed: N/A
  • any additional dependencies that are required for this change: N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

MultiFilter raises `StopIteration` if there are no tokens to filter. Added a check for this case and returned an empty token list.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

@github-actions github-actions bot added the Stale label May 26, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This PR was closed because it has been stalled for some time with no activity.

@github-actions github-actions bot closed this Jun 2, 2024
@chitochi
Copy link

Hello !

I had the same problem using Whoosh, I think it would be nice to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants