Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Accept match Option Feature #151

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Implemented Accept match Option Feature #151

merged 6 commits into from
Jul 29, 2022

Conversation

nscheibe
Copy link
Member

@nscheibe nscheibe commented Jul 8, 2022

The accept match option is a field option, which can replace a specified field with "AcceptAny<...>" and the value comparison will be ignored. Therefore it is a a kind of advanced ignore option, but generalises the value. This has the effect, that if we compare two snapshots, we do not see alle the ignored value fields as differences.

@nscheibe nscheibe requested a review from alisan3 July 8, 2022 10:10
alisan3
alisan3 previously approved these changes Jul 8, 2022
Copy link
Contributor

@alisan3 alisan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved without review as requested

@nscheibe
Copy link
Member Author

nscheibe commented Jul 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 29 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nscheibe nscheibe merged commit b0a1fca into master Jul 29, 2022
@nscheibe nscheibe deleted the acceptMatchOption branch July 29, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants