Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the readme to current image names #80

Merged
merged 1 commit into from
Mar 5, 2020
Merged

docs: update the readme to current image names #80

merged 1 commit into from
Mar 5, 2020

Conversation

emmjab
Copy link
Contributor

@emmjab emmjab commented Mar 4, 2020

No description provided.

@emmjab emmjab requested a review from rokroskar March 4, 2020 07:30
@lorenzo-cavazzi
Copy link
Member

ops sorry I see this late, otherwise I would probably not have pushed #82

Anyway, I would leave a convenient make all command and some sort of make base -- could also be an example like you can use make <name> to build a template, e.g. make py3.7

@emmjab
Copy link
Contributor Author

emmjab commented Mar 5, 2020

I think #82 is fine if you add the naming changes as well :)
maybe we can merge this and you can add the section back w/the updated make syntax in your PR?
thoughts?

@lorenzo-cavazzi
Copy link
Member

I thought we could leave the make all part directly, but it's ok also to re-add it in the other PR 🙁

@pameladelgado pameladelgado merged commit a4d5065 into master Mar 5, 2020
@emmjab emmjab deleted the docs-for-naming branch March 30, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

@rokroskar rokroskar Awaiting requested review from rokroskar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmjab @lorenzo-cavazzi @pameladelgado