chore: do not override RSTUDIO_VERSION in CI #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rokroskar I think we should disable the tests until they are fixed and merge this. The images seem to be working (or we need to manually check all of them). |
|
@leafty yes sure, that sounds good. I'm not really up to speed on how to fix these tests so some help would be appreciated there... |
|
tests may be a bit flaky now, but they should ultimately pass |
olevski
requested changes
Apr 24, 2024
olevski
reviewed
Apr 24, 2024
leafty
reviewed
May 14, 2024
rokroskar
force-pushed
the
rokroskar-patch-2
branch
from
9538265 to
be7ece5
Compare
fix acceptance test by using a fixed and unreleased version of the test package
rokroskar
force-pushed
the
rokroskar-patch-2
branch
from
be7ece5 to
16b4600
Compare
olevski
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No double-override.