-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use go-based powerline-shell #358
Conversation
I tested this on the project where previously the terminal prompt was hanging. It does not behave this way with the new powerline shell. |
@rokroskar I ran the problematic project again with the go powerline shell (btw the project is from Firat and it is not public). I cannot get the shell to hang at all. Even when I start the session immediately as soon as it is ready, then open one shell run As for needing the powerline fonts here is the relevant part from the repo/instructions: Namely it says:
Our old config used |
This does not fix #357 - I still get it to hang because the git prompt needs to call |
For me, starting a local session hangs the terminal with this project: https://renkulab.io/projects/rok.roskar/adore I do
(edit: I tried it with the new image from this PR) |
@rokroskar funny enough using this definitely prevents the shell hanging in Firat's project in a session in the web ui. Because I can consistently get the terminal to hang when the old powerline shell is used and it never hangs with the new one. |
Switch powerline shell to go.