Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do not add provenance metadata to images #329

Merged
merged 1 commit into from
Apr 6, 2023
Merged

chore: do not add provenance metadata to images #329

merged 1 commit into from
Apr 6, 2023

Conversation

rokroskar
Copy link
Member

Encoding provenance metadata in images seems to cause problems for many common docker libraries. See here for an explanation.

@rokroskar rokroskar marked this pull request as ready for review April 6, 2023 11:51
@rokroskar
Copy link
Member Author

Tested this by pinning the image renku/renkulab-py:3.10-cbcdd2e in a project and the notebook service was able to find it.

@olevski olevski self-requested a review April 6, 2023 16:01
olevski
olevski approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! That works as expected Rok.

@rokroskar rokroskar merged commit 7dcdc9d into master Apr 6, 2023
@rokroskar rokroskar deleted the rokroskar-patch-2 branch April 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rokroskar @olevski